Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: replace struct interface with one from crate #2014

Closed
wants to merge 3 commits into from
Closed

Windows: replace struct interface with one from crate #2014

wants to merge 3 commits into from

Conversation

i10416
Copy link

@i10416 i10416 commented Aug 28, 2021

I replaced the temporary struct with one from crate in windows/dark-mode.rs according to comment.

  • Tested on all platforms changed
  • Compilation warnings were addressed
  • cargo fmt has been run on this branch
  • cargo doc builds successfully
  • [] Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

@i10416 i10416 changed the title replace struct interface with one from crate Windows: replace struct interface with one from crate Aug 28, 2021
@maroider
Copy link
Member

maroider commented Aug 28, 2021 •
edited
Loading

Thanks for taking the time to contribute.

However, the change you've proposed is already being undertaken as a part of #2011.

@i10416 i10416 closed this Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@i10416 @maroider